atomFeedString.xml 2.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354
  1. <?xml version="1.0" encoding="utf-8"?>
  2. <feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us" updated="2009-10-04T01:35:58+00:00"><title>Code Review - My issues</title><link href="http://codereview.appspot.com/" rel="alternate"></link><link href="http://codereview.appspot.com/rss/mine/rsc" rel="self"></link><id>http://codereview.appspot.com/</id><author><name>rietveld&lt;&gt;</name></author><entry><title>rietveld: an attempt at pubsubhubbub
  3. </title><link href="http://codereview.appspot.com/126085" rel="alternate"></link><updated>2009-10-04T01:35:58+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:134d9179c41f806be79b3a5f7877d19a</id><summary type="html">
  4. An attempt at adding pubsubhubbub support to Rietveld.
  5. http://code.google.com/p/pubsubhubbub
  6. http://code.google.com/p/rietveld/issues/detail?id=155
  7. The server side of the protocol is trivial:
  8. 1. add a &amp;lt;link rel=&amp;quot;hub&amp;quot; href=&amp;quot;hub-server&amp;quot;&amp;gt; tag to all
  9. feeds that will be pubsubhubbubbed.
  10. 2. every time one of those feeds changes, tell the hub
  11. with a simple POST request.
  12. I have tested this by adding debug prints to a local hub
  13. server and checking that the server got the right publish
  14. requests.
  15. I can&amp;#39;t quite get the server to work, but I think the bug
  16. is not in my code. I think that the server expects to be
  17. able to grab the feed and see the feed&amp;#39;s actual URL in
  18. the link rel=&amp;quot;self&amp;quot;, but the default value for that drops
  19. the :port from the URL, and I cannot for the life of me
  20. figure out how to get the Atom generator deep inside
  21. django not to do that, or even where it is doing that,
  22. or even what code is running to generate the Atom feed.
  23. (I thought I knew but I added some assert False statements
  24. and it kept running!)
  25. Ignoring that particular problem, I would appreciate
  26. feedback on the right way to get the two values at
  27. the top of feeds.py marked NOTE(rsc).
  28. </summary></entry><entry><title>rietveld: correct tab handling
  29. </title><link href="http://codereview.appspot.com/124106" rel="alternate"></link><updated>2009-10-03T23:02:17+00:00</updated><author><name>email-address-removed</name></author><id>urn:md5:0a2a4f19bb815101f0ba2904aed7c35a</id><summary type="html">
  30. This fixes the buggy tab rendering that can be seen at
  31. http://codereview.appspot.com/116075/diff/1/2
  32. The fundamental problem was that the tab code was
  33. not being told what column the text began in, so it
  34. didn&amp;#39;t know where to put the tab stops. Another problem
  35. was that some of the code assumed that string byte
  36. offsets were the same as column offsets, which is only
  37. true if there are no tabs.
  38. In the process of fixing this, I cleaned up the arguments
  39. to Fold and ExpandTabs and renamed them Break and
  40. _ExpandTabs so that I could be sure that I found all the
  41. call sites. I also wanted to verify that ExpandTabs was
  42. not being used from outside intra_region_diff.py.
  43. </summary></entry></feed> `